Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Use fixed version (Cargo.lock) of sqlx-cli and mediator binary for mediator-ci #1319

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

nain-F49FF806
Copy link
Member

@nain-F49FF806 nain-F49FF806 commented Dec 25, 2024

While we lock rust toolchain version in the repo, A transitive dependency (home) for above binaries has upgraded it's MSRV (1.81) to greater than the rust version currently used in this repo (1.79). This causes build to fail.

So we build the binaries with the --locked option to use known working dependency version tree.

Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
@nain-F49FF806 nain-F49FF806 changed the title fix: use fixed version of sqlx-cli and it's Cargo.lock for mediator-ci (fix) Use fixed version of sqlx-cli and it's Cargo.lock in mediator-ci Dec 25, 2024
Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
some dependencies have increased minimum supported rust version (msrv). This causes breakage as we use an earlier 1.79

Use the lockfile to use versions of dependencies known to work.

Signed-off-by: Naian <126972030+nain-F49FF806@users.noreply.github.com>
@nain-F49FF806 nain-F49FF806 changed the title (fix) Use fixed version of sqlx-cli and it's Cargo.lock in mediator-ci (fix) Use fixed version (Cargo.lock) of sqlx-cli and mediator binary Dec 25, 2024
@nain-F49FF806 nain-F49FF806 changed the title (fix) Use fixed version (Cargo.lock) of sqlx-cli and mediator binary (fix) Use fixed version (Cargo.lock) of sqlx-cli and mediator binary Dec 25, 2024
@nain-F49FF806 nain-F49FF806 changed the title (fix) Use fixed version (Cargo.lock) of sqlx-cli and mediator binary (fix) Use fixed version (Cargo.lock) of sqlx-cli and mediator binary for mediator-ci Dec 25, 2024
@gmulhearn gmulhearn merged commit c5a801a into hyperledger:main Feb 13, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants